Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.70】[PHI decoupling] move jit kernels from fluid to phi #50911

Merged
merged 6 commits into from
Mar 3, 2023
Merged

【Hackathon No.70】[PHI decoupling] move jit kernels from fluid to phi #50911

merged 6 commits into from
Mar 3, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Feb 25, 2023

PR types

Others

PR changes

Others

Describe

@paddle-bot
Copy link

paddle-bot bot commented Feb 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Feb 25, 2023
@gouzil gouzil mentioned this pull request Feb 25, 2023
Closed
@gouzil
Copy link
Member Author

gouzil commented Feb 27, 2023

ci 需要批准 @luotao1 @YuanRisheng @XiaoguangHu01

@YuanRisheng
Copy link
Contributor

ci 需要批准 @luotao1 @YuanRisheng @XiaoguangHu01

先把不需要批准的ci过了，需要批准的后续我们会review

@luotao1
Copy link
Contributor

luotao1 commented Mar 2, 2023

需要按照黑客松流程在总issue下回复状态：

YuanRisheng
YuanRisheng reviewed Mar 2, 2023
View reviewed changes
paddle/phi/kernels/funcs/fc_functor.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/funcs/fc_functor.cc Outdated Show resolved Hide resolved
paddle/phi/kernels/funcs/jit/README.md Outdated Show resolved Hide resolved
@gouzil
Copy link
Member Author

gouzil commented Mar 3, 2023

需要按照黑客松流程在总issue下回复状态：

done

YuanRisheng
YuanRisheng approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有个隐藏内容，这个任务是进阶题目，不仅仅是因为其涉及到文件比较多，还有另一个原因是需要删除掉jit下未使用的代码。可以分俩个PR来做一下，这个PR先合入，然后下个PR需要删除掉jit里不使用的代码。这里需要对jit代码稍微看看了解一下，我这边提示一下就是jit目录下注册的kernel有些或许没被Paddle用到可以尝试删除

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 2d36c9a into PaddlePaddle:develop Mar 3, 2023
@gouzil
Copy link
Member Author

gouzil commented Mar 3, 2023

有个隐藏内容，这个任务是进阶题目，不仅仅是因为其涉及到文件比较多，还有另一个原因是需要删除掉jit下未使用的代码。可以分俩个PR来做一下，这个PR先合入，然后下个PR需要删除掉jit里不使用的代码。这里需要对jit代码稍微看看了解一下，我这边提示一下就是jit目录下注册的kernel有些或许没被Paddle用到可以尝试删除

好的，会在近期提交pr

@Ligoml Ligoml mentioned this pull request Mar 7, 2023
Closed
@gouzil gouzil mentioned this pull request Mar 12, 2023
Merged
6 tasks
@gouzil gouzil deleted the decoupling_jit_kernels branch March 24, 2023 07:07
@YuanRisheng YuanRisheng mentioned this pull request Mar 24, 2023
Closed
@gouzil gouzil mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

@cloud2009 cloud2009

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gouzil @YuanRisheng @luotao1 @XiaoguangHu01 @cloud2009