[Tensor Operants & Prim] Tensor pow API uses elementwise_pow #50886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
force-pushed
the
tensor_attach_pow
branch
from
79844a5
to
fb82552
Compare
jiahy0825
force-pushed
the
tensor_attach_pow
branch
from
fb82552
to
36ae90a
Compare
YuanRisheng
approved these changes
Feb 27, 2023
| @@ -29,6 +29,8 @@ | |||
|
|
|||
| indent = " " | |||
|
|
|||
| specific_ops_map = {"elementwise_pow": "pow"} | |||
There was a problem hiding this comment.
Next PR fix this.
zyfncg
reviewed
Feb 27, 2023
| } | ||
|
|
||
| Tensor EagerTensorOperants::pow(const Tensor& x, const Scalar& y) { | ||
| return ::elementwise_pow_ad_func(x, ::full_like_ad_func(x, y)); |
There was a problem hiding this comment.
此处来自组合算子需求，要求尽可能使用基础算子，使用 elementwise + full_like 做组合，可以节省一个 pow 算子（接口）
Prim requires to use basic operators as much as possible. Using elementwise + full_like can save the operator of pow.
zyfncg
approved these changes
Feb 27, 2023
jiahy0825
added a commit
to jiahy0825/Paddle
that referenced
this pull request
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Tensor 重载 pow 时，使用 full + elementwise_pow 的组合方式进行调用。
目的：组合算子需求，尽量拆分为基础算子，相当于节省了
pow(const Tensor& x, const Scalar& y = 1.0f)这个算子，统一使用elementwise_powWhen attaching
powto Tensor, usesfull + elementwise_powto composepowMotivation: Requirements from prim, divide pow into fundamental operator can save the operator of
pow(const Tensor& x, const Scalar& y = 1.0f).