Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add topk prim backward #50679

Merged
merged 100 commits into from
Mar 1, 2023
Merged

add topk prim backward #50679

merged 100 commits into from
Mar 1, 2023

Conversation

zhengqiwen1997
Copy link
Contributor

@zhengqiwen1997 zhengqiwen1997 commented Feb 20, 2023 •
edited
Loading

PR types

Others

PR changes

OPs

Describe

add topk prim backward

JiabinYang and others added 30 commits February 3, 2023 05:44
@JiabinYang
tmp gather vjp
abba3f7
@JiabinYang
merge develop
86f7cc7
@JiabinYang
support gather
ff51755
@JiabinYang
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
a37ce9f 
… add_gather_vjp
@JiabinYang
remove useless code
acea6c4
@JiabinYang
fix compiling error
422e93e
@JiabinYang
fix ut
49b8dd7
@JiabinYang
add eager test
6cb7e01
@JiabinYang
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
41ebe1b 
… add_gather_vjp
@JiabinYang
add eager test
66602a4
@JiabinYang
add seed
73f2822
@JiabinYang
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
238a0fb 
… add_gather_vjp
@zhengqiwen1997
small change
7502b31
@JiabinYang
fix cpu error
95fab71
@JiabinYang
merge develop
af37274
@zhengqiwen1997
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
3106480 
… topk_grad_comp
@JiabinYang
fix transpose op compat
d297072
@JiabinYang
remove tensor index case
147436f
@JiabinYang
fix prim_cinn
f82f1d6
@zhengqiwen1997
small commit
cdd3dbb
@zhengqiwen1997
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
9e50329 
… topk_grad_comp
@GGBond8488
add cumsum prim backward
3fd552b
@zhengqiwen1997
small commit
d4907e8
@GGBond8488
skip aixs=None test case
91e4152
@GGBond8488
fix op generante eror
830ea51
@GGBond8488
fix static test error
1f87a33
@GGBond8488
remove unused code
b035a91
@GGBond8488
fix static test error
3507a6b
@zhengqiwen1997
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
ac97fac 
… topk_grad_comp
@GGBond8488
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
29a4801 
… add_cumsum_grad_for_prim
zhengqiwen1997 and others added 22 commits February 24, 2023 06:35
@zhengqiwen1997
pass the static test
910d41c
@zhengqiwen1997
conflict resolved
e3a9eef
@zhengqiwen1997
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
ffe8930 
… topk_grad_comp
@GGBond8488
fix typro
ca54bd3
@zhengqiwen1997
modify optest and delete old test files
bd3310f
@zhengqiwen1997
remove normal test_top_k_op test
556a824
@GGBond8488
fix typro
596895f
@GGBond8488
pass axis=None test case
2631fd4
@zhengqiwen1997
buffer comment
42dcfc2
@zhengqiwen1997
for debug
04e5819
@zxcd
add silu fp16 unit test.
a4ccc9f
@Charles-hit
add static guard
1683995
@zhengqiwen1997
Merge commit 'refs/pull/50971/head' of https://github.com/PaddlePaddl…
0d90712 
…e/Paddle into topk_grad_comp
@zhengqiwen1997
merge
47835ca
@GGBond8488
remove forward prim test
d478f09
@GGBond8488
remove same name axis
dc24092
@zhengqiwen1997
modify the test_top_v2_op.py to pass all local tests
e002a82
@zhengqiwen1997
delete the useless testcase
d75c5bd
@zhengqiwen1997
merge conflict
5af4155
@zhengqiwen1997
Merge commit 'refs/pull/50838/head' of https://github.com/PaddlePaddl…
e20bb2a 
…e/Paddle into topk_grad_comp
@zhengqiwen1997
fix mistake
bc485d1
@zhengqiwen1997
Merge branch 'develop' into topk_grad_comp
c87ad2a
xiaoguoguo626807
xiaoguoguo626807 reviewed Mar 1, 2023
View reviewed changes
python/paddle/fluid/tests/unittests/test_top_k_v2_op.py Outdated
self.python_api = paddle.topk
self.dtype = np.float64
self.dtype = np.float16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to add new test for different dtype

python/paddle/fluid/tests/unittests/test_top_k_v2_op.py Outdated Show resolved Hide resolved
xiaoguoguo626807
xiaoguoguo626807 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Charles-hit Charles-hit merged commit 296b3ff into PaddlePaddle:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@Charles-hit Charles-hit Charles-hit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhengqiwen1997 @Charles-hit @xiaoguoguo626807 @JiabinYang @GGBond8488 @zxcd