【prim】Matmul double grad composite api #50452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…807/Paddle into matmul_double_grad
|
你的PR提交成功，感谢你对开源项目的贡献! |
Charles-hit
reviewed
Feb 21, 2023
| for (int64_t i = 0; i < axis_size; i++) { | ||
| if (axis[i] < 0) { | ||
| axis_[i] = axis[i] + x_dim_size; | ||
| std::cout << "axis_[" << i << "] = " << axis[i]; |
| desired=dx_, | ||
| rtol=TOLERANCE[d_type]['rtol'], | ||
| atol=TOLERANCE[d_type]['atol'], | ||
| ) |
JiabinYang
previously approved these changes
Feb 22, 2023
| @@ -78,11 +81,38 @@ static phi::DDim get_reduce_dims(const phi::DDim& x_dims, | |||
| return get_reduce_dims_from_out(out_dims, x_dims); | |||
| } | |||
|
|
|||
| static std::vector<int> get_reduce_dims(const Tensor& dx, | |||
There was a problem hiding this comment.
when matmul used broadcast [1, 4, 3] * [2, 3, 4] =[2, 4, 4] ,x will be broadcast to [2, 4, 3] we need to compute the true dims [1, 4, 3] reduce dims will be [0]
| @param.parameterized_class( | ||
| ('primal0', 'primal1', 'primal2', 'trans_0', 'trans_1', 'dtype'), | ||
| [ | ||
| # ( |
There was a problem hiding this comment.
Add to do here to uncomment it when we fix static mode
| @@ -93,7 +93,7 @@ class StaticCompositeContext { | |||
| StaticCompositeContext() | |||
| : current_block_desc_(nullptr), | |||
| generator_(new UniqueNameGenerator()), | |||
| skip_comp_ops_({"matmul_v2"}) {} | |||
| skip_comp_ops_({"matmul_v2", "matmul_v2_grad"}) {} | |||
There was a problem hiding this comment.
leave todo here to remove this when we fix static
zhwesky2010
previously approved these changes
Feb 27, 2023
xiaoguoguo626807
dismissed stale reviews from XiaoguangHu01, zhwesky2010, and JiabinYang
via
8cd6842
zhwesky2010
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
matmul 二阶组合算子实现