Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix optminizer _set_auxiliary_var bug #50335

Conversation

wanghuancoder
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

#49864 滞后了found inf
但借助了_set_auxiliary_var向optimizer中传递 found inf。
分布式重写了很多优化器,包裹了框架的优化器。这导致_set_auxiliary_var没有传递下来。本PR修复了该问题。

@paddle-bot
Copy link

paddle-bot bot commented Feb 8, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit c44005f into PaddlePaddle:develop Feb 9, 2023
veyron95 added a commit that referenced this pull request Feb 23, 2023
veyron95 added a commit to veyron95/Paddle that referenced this pull request Feb 23, 2023
phlrain pushed a commit that referenced this pull request Feb 24, 2023
* Revert "fixoptminizer _set_auxiliary_var bug (#50335)"

This reverts commit c44005f.

* Revert "refine optimizer create accumulators (#50188)"

This reverts commit 244e754.

* Revert "fix found_inf bug for custom optimizer (#50158)"

This reverts commit 64573f9.

* Revert "refine amp scaler found_inf (#49864)"

This reverts commit 382e9a0.

* fix code format

* fix conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants