Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning to the docstring of Parameters.to_tar() #5033

Merged
merged 2 commits into from
Oct 24, 2017

Conversation

pengli09
Copy link
Contributor

No description provided.

Save parameters to a tar file.

WARNING: Do not use this function to save parameters directly unless you
know exactly what you are doing. `paddle.v2.trainer.SGD.save_parameter_to_tar(f)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“unless you know exactly what you are doing. ” 这个英文注释不太好。为什么不直接解释有什么风险呢?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised. Thx!

Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pengli09 pengli09 merged commit 25588a3 into PaddlePaddle:develop Oct 24, 2017
@pengli09 pengli09 deleted the add-a-warning branch October 24, 2017 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants