add book04.word2vec train test #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 22, 2017
| @@ -20,7 +20,7 @@ def test_fit_a_line(self): | |||
| avg_cost = layers.mean(x=cost, program=program) | |||
| self.assertIsNotNone(avg_cost) | |||
| program.append_backward(avg_cost) | |||
| print str(program) | |||
| # print str(program) | |||
There was a problem hiding this comment.
Do not change the previous unit tests.
You can select the test method in runtime, by
python -m unittest test_layers.TestBook.test_fit_a_line
reyoung
reviewed
Oct 22, 2017
wangkuiyi
reviewed
Oct 23, 2017
| @@ -18,6 +18,10 @@ limitations under the License. */ | |||
| namespace paddle { | |||
| namespace framework { | |||
|
|
|||
| VarDesc::VarType VarDescBind::GetType() const { return desc_.type(); } | |||
There was a problem hiding this comment.
I see that we added methods GetType and SetType, but I don't see them being used anyway in this PR. Just a kindly reminder -- do we really need them?
There was a problem hiding this comment.
I just modify the syntax of these two methods. These two methods are used here.
Before, the methods implementation are also in header file. I move the implementation to source file to take consistency with other methods in class VarDescBind.
reyoung
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx #5003