Generate some static graph ops #49906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
reviewed
Jan 19, 2023
cmake/operators.cmake
Outdated
Comment on lines
580
to
583
| if(NOT ${TARGET} STREQUAL "activation") | ||
| file(APPEND ${pybind_file} "USE_NO_KERNEL_OP(${TARGET});\n") | ||
| set(pybind_flag 1) | ||
| endif() |
There was a problem hiding this comment.
此处是否可以根据 WITH_GPU 来判断，不使用这种 trick 的方式？
Is this trick needed? Can we use WITH_GPU to replace this trick?
There was a problem hiding this comment.
此处判断冗余，已删除。谢谢！
zyfncg
reviewed
Jan 19, 2023
cmake/operators.cmake
Outdated
Comment on lines
578
to
582
| # TODO:(lizhiyu) This just for activation. If not using this assert, | ||
| # there will be "USE_NO_KERNEL_OP(activation)"in pybind.h in the case of WITH_GPU=OFF. | ||
| if(NOT ${TARGET} STREQUAL "activation") | ||
| file(APPEND ${pybind_file} "USE_NO_KERNEL_OP(${TARGET});\n") | ||
| set(pybind_flag 1) |
There was a problem hiding this comment.
上面加了处理之后这里还需要对activation再单独处理吗？
There was a problem hiding this comment.
此处判断冗余，已删除。谢谢！
zyfncg
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Ops
Describe
基于yaml生成broadcast_tensors、pow的静态图代码，并移除原有代码