ensure ids in lookup table op must be a column vector #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Oct 23, 2017
paddle/operators/lookup_table_op.cc
Outdated
| "An input with type int32 or int64" | ||
| "contains the ids to be looked up in W." | ||
| "Ids must be a column vector with rank = 2." | ||
| "The 1st dimension is batch size, and the 2nd dimension must be 1"); |
There was a problem hiding this comment.
Remove: “The 1st dimension is batch size”, since for sequence index input, the 1st dimension is the total of words number in this mini-batch, not batch size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4986