Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allgather on xpu #49815

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Fix allgather on xpu #49815

merged 1 commit into from
Jan 15, 2023

Conversation

sljlp
Copy link
Contributor

@sljlp sljlp commented Jan 13, 2023

PR types

Bug fixes

PR changes

Others

Describe

  1. update xccl lib
  2. when using comm_ctx, the allocator should be set manually.

@paddle-bot
Copy link

paddle-bot bot commented Jan 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaociZhang
XiaociZhang approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@XiaociZhang XiaociZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LiYuRio
LiYuRio approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sljlp sljlp merged commit 6a56bce into PaddlePaddle:develop Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaociZhang XiaociZhang XiaociZhang approved these changes

@LiYuRio LiYuRio LiYuRio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sljlp @LiYuRio @XiaociZhang