Add a C++ program that prints operator document in JSON format #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Oct 20, 2017
paddle/pybind/print_operators_doc.cc
Outdated
| int main() { | ||
| std::cout << "[\n"; | ||
| for (auto iter : paddle::framework::OpInfoMap::Instance().map()) { | ||
| PrintOpProto(iter.first, iter.second); |
There was a problem hiding this comment.
I think it might have an extra comma at the end of list.
There was a problem hiding this comment.
You are right -- Thank you for the very careful review. It is just that I don't have a good idea not to print it.
reyoung
reviewed
Oct 20, 2017
paddle/pybind/print_operators_doc.cc
Outdated
|
|
||
| int main() { | ||
| std::cout << "[\n"; | ||
| for (auto iter : paddle::framework::OpInfoMap::Instance().map()) { |
There was a problem hiding this comment.
for (auto& iter : ...)
Use reference to reduce copy.
reyoung
reviewed
Oct 20, 2017
paddle/pybind/pybind.cc
Outdated
| "Serialize OpProto Error. This could be a bug of Paddle."); | ||
| ret_values.emplace_back(str); | ||
| }); | ||
| for (auto iter : OpInfoMap::Instance().map()) { |
There was a problem hiding this comment.
auto& iter
Use reference to reduce copy
reyoung
reviewed
Oct 20, 2017
paddle/pybind/pybind.cc
Outdated
| }); | ||
| for (auto iter : OpInfoMap::Instance().map()) { | ||
| auto type = iter.first; | ||
| auto info = iter.second; |
There was a problem hiding this comment.
auto& info
Use reference to reduce copy
jetfuel
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4901