Fix reduce func bug in process_group_bkcl #49749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also catch up with a recent process_group PR that failed to add XPU branch. Note that reduce is still accomplished by allreduce for xpu. Fix this should xccl lib be updated.
|
你的PR提交成功，感谢你对开源项目的贡献! |
QingshuChen
approved these changes
Jan 12, 2023
| @@ -277,7 +277,8 @@ std::shared_ptr<ProcessGroup::Task> ProcessGroupBKCL::Reduce( | |||
| const phi::DenseTensor& input, | |||
| BKCLContext_t comm, | |||
| const XPUStream& stream) { | |||
| phi::DenseTensor output_t(*output); | |||
| phi::DenseTensor output_t; | |||
| paddle::framework::TensorCopy(*output, platform::XPUPlace(), &output_t); | |||
There was a problem hiding this comment.
TensorCopy会自己分配空间，对吧？
之后可以考虑直接实现一个Reduce，在模型并行sharding中Reduce用的比较多；
There was a problem hiding this comment.
会自己分配空间，reduce等xccl kernel实现后我更新一下
|
你的PR已合入Paddle库，请关注后续测试结果。 |
yjjiang11
pushed a commit
to yjjiang11/Paddle
that referenced
this pull request
Jan 13, 2023
* Fix reduce func bug in process_group_bkcl Also catch up with a recent process_group PR that failed to add XPU branch. Note that reduce is still accomplished by allreduce for xpu. Fix this should xccl lib be updated. * fix compile issue for non-XPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Fix reduce func bug in process_group_bkcl. Also catch up with a recent process_group PR that failed to add XPU branch. Note that reduce is still accomplished by allreduce for xpu. Fix this should xccl lib be updated.