-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove oneDNN-specific attributes from matmul #49444
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
Now, we are going to delete all oneDNN-specific attributes from base ops. Do you think we could just delete this checkpoint and restore matmul version 0 or new checkpoint should be added and matmul would be version 2 then? @YuanRisheng, @chenwhql please advice |
@YuanRisheng please help review, approve and merge |
@zhangting2020 could you please approve removing decorator |
@XiaoguangHu01 could you please approve exceeding limit of 20 modified files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
OPs
Describe
In #49515 each fuse done for
matmul
andmatmul_v2
was converted to be executed asfused_matmul
. Fusion logic was extracted to dedicated fused op and fused kernel. As basematmul
is now not fused with anything, all extra attributes can be deleted from OPMaker, .pbtxt file and unit tests.Changes done in this PR:
matmul
op and kernel,matmul_v2
.