Cache scope in While Op during Inference. #49083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
✅ This PR's description meets the template requirements! |
carryyu
changed the title
heavengate
reviewed
Dec 16, 2022
| } | ||
| } | ||
|
|
||
| private: | ||
| mutable std::shared_ptr<framework::Executor> executor_{nullptr}; | ||
| mutable std::unique_ptr<framework::ExecutorPrepareContext> ctx_{nullptr}; | ||
| mutable std::shared_ptr<framework::InterpreterCore> core_{nullptr}; | ||
| mutable framework::Scope *inference_cache_scope_ = nullptr; |
There was a problem hiding this comment.
- while op是训练推理共用的，这里叫inference_xxx不太合理
- 当前的修改逻辑对训练有没有影响 @zhhsplendid 看下？
There was a problem hiding this comment.
- while op是训练推理共用的，这里叫inference_xxx不太合理
- 当前的修改逻辑对训练有没有影响 @zhhsplendid 看下？
- 当前暂时只针对旧执行器上的推理阶段做了scope复用，这样影响面可以限制在推理侧，因为担心对训练侧产生没发现的问题。
- 如果训练侧也可以复用scope 这里可以修改的更通用一些，暂时只针对推理做了scope缓存～
yuanlehome
reviewed
Dec 16, 2022
jiweibo
reviewed
Dec 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
Cache scope in While Op during Inference.
解决方法：a. While Op不再每次运行完后就释放掉scope。 b. 使While Op中的Op不进行复用（同之前的做法）。