[new executor]Support CINN use InterpreterCore #48911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
CtfGo
reviewed
Dec 19, 2022
zhiqiu
previously approved these changes
Dec 23, 2022
Comment on lines
108
to
109
| framework::Scope* scope1 = new framework::Scope(); | ||
| RunAndCheck(place, scope1); |
There was a problem hiding this comment.
Suggested change
| framework::Scope* scope1 = new framework::Scope(); | |
| RunAndCheck(place, scope1); | |
| framework::Scope scope1; | |
| RunAndCheck(place, &scope1); |
phlrain
reviewed
Dec 26, 2022
| framework::Scope& exec_scope = scope.NewScope(); | ||
| auto* pe = launch_context->InitializePE(place, &exec_scope); | ||
| pe->RunWithoutFetch(launch_context->GetSkipEagerVars()); | ||
| if (FLAGS_enable_interpretercore_launch_cinn) { |
There was a problem hiding this comment.
从逻辑上，把interpreter core 放在pe的判断外面，是不是更好一些
There was a problem hiding this comment.
根据@CtfGo的review意见，目前CINN的一些开发工作通过FLAGS_enable_pe_launch_cinn控制，因此暂时将新执行器模块放在这个flag的控制下，后续清理pe的工作开展的时候会吧FLAGS_enable_pe_launch_cinn全局替换为FLAGS_enable_interpretercore_launch_cinn
phlrain
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
CINN 后端执行支持 InterpreterCore，具体工作包括：