[CodeStyle][E401][F811] remove redefined imports and variables #48538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
SigureMo
commented
Dec 1, 2022
| @@ -71,7 +71,7 @@ def test_sub_scalar(self): | |||
| np.testing.assert_allclose(a_np - 10, b_np, rtol=1e-05) | |||
|
|
|||
| @prog_scope() | |||
| def test_radd_scalar(self): | |||
| def test_rsub_scalar(self): | |||
There was a problem hiding this comment.
这里测试的是 __rsub__ 但和上面 __radd__ 重名了，因此修改前 test_radd_scalar 其实没有跑，里面有一个忘记 unpack 的 b_np，就 unpack 了下～
| @@ -184,7 +184,7 @@ def func_test_create_param_lr_with_no_1_value_for_coverage(self): | |||
| z.backward() | |||
| opt.step() | |||
|
|
|||
| def func_test_create_param_lr_with_no_1_value_for_coverage(self): | |||
| def test_create_param_lr_with_no_1_value_for_coverage(self): | |||
| with _test_eager_guard(): | ||
| self.func_tensor_str_bf16() | ||
| self.func_tensor_str_bf16() | ||
|
|
| @@ -117,7 +117,7 @@ def _elementwise_mul_flops(input_shapes, attrs): | |||
|
|
|||
|
|
|||
| @register_flops("elementwise_div") | |||
| def _elementwise_mul_flops(input_shapes, attrs): | |||
| def _elementwise_div_flops(input_shapes, attrs): | |||
| python/paddle/fluid/tests/unittests/test_activation_nn_grad.py: F811 | ||
| python/paddle/fluid/tests/unittests/test_lstm_cudnn_op.py: F811 | ||
| python/paddle/fluid/tests/unittests/test_matmul_v2_op.py: F811 | ||
| python/paddle/fluid/tests/unittests/test_rrelu_op.py: F811 |
There was a problem hiding this comment.
这五个单测 F811 问题导致隐藏了一些错误，修复时暴露了这些问题并需要修复下，可能需要修改下单测，因此拆分到之后 PR 处理
这个 PR 里处理的都是一些显而易见的错误～
SigureMo
changed the title
luotao1
approved these changes
Dec 2, 2022
lxsbupt
pushed a commit
to lxsbupt/Paddle
that referenced
this pull request
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
本 PR 消除 E401（multiple imports on one line）和 F811（redefinition of unused
namefrom lineN）错误码E401 就是多个 import 在一行（仅仅是
import不包含from import，后者推荐写在一起），拆开即可，这个本就极少，因此不单独作为一个 PR 了F811 绝大多数是重复的 import，isort 引入过程中已经解决了绝大部分，剩下的根据情况手动解决，主要包含以下问题：
noqaRelated links
namefrom lineNcattidea/paddle-flake8-project#78