Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2St] drop Executor and ParallelExecutor support for JITLayer #48298

Merged

Conversation

SigureMo
Copy link
Member

PR types

Others

PR changes

Others

Describe

Remove deprecated ExecutorEngine and PEEngine, see 动转静功能扩展和旧接口退场 - 移除 Exectuor、ParallelExecutor 两个内核执行器

@paddle-bot
Copy link

paddle-bot bot commented Nov 23, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@0x45f 0x45f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议修改一下flags.cc中FLAGS_jit_engine_type的相关注释,可以下个PR再进行修改

@Aurelius84
Copy link
Contributor

Remove deprecated ExecutorEngine and PEEngine

@SigureMo flag.cc 文件中关于jit_engine_type 的注释后续可否考虑单独提一个PR清理下?

@SigureMo
Copy link
Member Author

SigureMo commented Nov 24, 2022

@SigureMo flag.cc 文件中关于jit_engine_type 的注释后续可否考虑单独提一个PR清理下?

嗯嗯好哒~

@Aurelius84 Aurelius84 merged commit 5664306 into PaddlePaddle:develop Nov 24, 2022
@SigureMo SigureMo deleted the dy2st/backend/remove-legacy-engines branch November 24, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants