Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][black][2.4] format the release/2.4 branch code with black #47644

Closed
wants to merge 2 commits into from

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Nov 3, 2022

PR types

Others

PR changes

Others

Describe

#46014,只不过是 release/2.4 分支

pre-commit-config.yaml 中的 exclude 字段也添加到 release/2.4 中,即

# Exclude all third-party libraries and auto-generated files globally
exclude: |
    (?x)^(
        patches/.+|
        paddle/fluid/framework/fleet/heter_ps/cudf/.+|
        paddle/fluid/distributed/ps/thirdparty/round_robin.h|
        python/paddle/utils/gast/.+|
        .+_py2\.py|
        python/paddle/fluid/tests/unittests/npu/.+|
        python/paddle/fluid/tests/unittests/mlu/.+
    )$

之后直接全局格式化即可

pre-commit run black --all-files

之后由于 python/paddle/tests/hubconf.py 测试对于 docstring 格式敏感,需要 skip 一下即可

@paddle-bot
Copy link

paddle-bot bot commented Nov 3, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Nov 3, 2022
@luotao1
Copy link
Contributor

luotao1 commented Nov 4, 2022

NPU 流水线问题(大量单测失败,可能需要暂时 revert?)

可以把NPU的先revert

@SigureMo SigureMo changed the title [WIP][CodeStyle][black][2.4] format the release/2.4 branch code with black [CodeStyle][black][2.4] format the release/2.4 branch code with black Nov 5, 2022
@luotao1
Copy link
Contributor

luotao1 commented Nov 7, 2022

@XiaoguangHu01 建议:

@luotao1 luotao1 closed this Nov 7, 2022
@SigureMo SigureMo deleted the black/2.4 branch November 7, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants