Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI]Standardise some C++ API (Part3) #47532

Merged
merged 3 commits into from
Nov 2, 2022
Merged

[PHI]Standardise some C++ API (Part3) #47532

merged 3 commits into from
Nov 2, 2022

Conversation

YuanRisheng
Copy link
Contributor

@YuanRisheng YuanRisheng commented Nov 1, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

标准化batch_norm/conv3d/depthwise_conv2d c++ api，去除extra参数与python对齐
后续还会继续对接口标准化，此PR是系列工作的第三个PR
相关CustomDevice修改PR：PaddlePaddle/PaddleCustomDevice#175

@paddle-bot
Copy link

paddle-bot bot commented Nov 1, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jiahy0825
jiahy0825 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@jiahy0825 jiahy0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZzSean
ZzSean approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for CI-OP-Benchmark

This was referenced Nov 2, 2022
Closed
Merged
XiaoguangHu01
XiaoguangHu01 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit fe8c679 into PaddlePaddle:develop Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@ZzSean ZzSean ZzSean approved these changes

@chenwhql chenwhql chenwhql approved these changes

@jiahy0825 jiahy0825 jiahy0825 approved these changes

@zyfncg zyfncg zyfncg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YuanRisheng @zyfncg @jiahy0825 @chenwhql @ZzSean @XiaoguangHu01