-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto Parallel] Merge the python and c++ impls of ProcessMesh #47503
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
f456efa
to
0ce3633
Compare
… improve_dist_attr
@@ -131,7 +137,7 @@ void BindAutoParallel(py::module *m) { | |||
const std::vector<std::string> &>(), | |||
py::arg("name"), | |||
py::arg("shape"), | |||
py::arg("process_ids"), | |||
py::arg("device_ids"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些接口对外开放了吗?这处修改是否有兼容性风险?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
暂时不对外开放。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…into improve_dist_attr
…into process_mesh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
ProcessMesh
:topology
->shape
processes
->process_ids