Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auto Parallel] Merge the python and c++ impls of ProcessMesh #47503

Merged
merged 16 commits into from
Dec 26, 2022

Conversation

aoyulong
Copy link
Contributor

@aoyulong aoyulong commented Oct 31, 2022

PR types

Others

PR changes

Others

Describe

  • Merge the python and c++ impls
    • The python ProcessMesh is a wrapper of the c++ ProcessMesh (by inheritance).
  • Rename the two methods of ProcessMesh:
    • topology -> shape
    • processes -> process_ids

@paddle-bot
Copy link

paddle-bot bot commented Oct 31, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@aoyulong aoyulong changed the title Rename the methods of ProcessMesh [Auto Parallel] Merge the python and c++ impls of ProcessMesh Nov 23, 2022
@@ -131,7 +137,7 @@ void BindAutoParallel(py::module *m) {
const std::vector<std::string> &>(),
py::arg("name"),
py::arg("shape"),
py::arg("process_ids"),
py::arg("device_ids"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些接口对外开放了吗?这处修改是否有兼容性风险?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂时不对外开放。

XiaoguangHu01
XiaoguangHu01 previously approved these changes Nov 24, 2022
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoyulong aoyulong merged commit 1c0afa7 into PaddlePaddle:develop Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants