Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] fix three types of compiler warnings on macOS #47341

Merged
merged 1 commit into from
Oct 26, 2022
Merged

[CodeStyle] fix three types of compiler warnings on macOS #47341

merged 1 commit into from
Oct 26, 2022

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Oct 26, 2022

PR types

Others

PR changes

Others

Describe

Fix uninitialized, tautological-constant-out-of-range-compare and literal-conversion warning on macOS.

cat before.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
   4 [-Wc++17-extensions]
   3 [-Wunknown-warning-option]
   2 [-Wexceptions]
   1 [-Wuninitialized]
   1 [-Wtautological-constant-out-of-range-compare]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]
   1 [-Wliteral-conversion]
cat after.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
   4 [-Wc++17-extensions]
   2 [-Wexceptions]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]

Compiler Warning tracking:

@GreatV
Copy link
Contributor Author

GreatV commented Oct 26, 2022

@luotao1 @zhiqiu

@luotao1 luotao1 merged commit 076c41e into PaddlePaddle:develop Oct 26, 2022
@GreatV GreatV deleted the fix_macos_warning branch October 26, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants