fix dygraph higer node creation #47231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
reviewed
Oct 24, 2022
| return ( | ||
| next_grad_node_creation_str, | ||
| next_grad_node_out_list, | ||
| next_node_generator.backward_forward_inputs_map, | ||
| has_higher_order_node, |
There was a problem hiding this comment.
表示状态信息的has_higher_order_node放在开头或许更合适一些
Comment on lines
1827
to
1829
| \"don't intend calculating higher order \" | ||
| \"derivatives, please set `create_graph` to \" | ||
| \"False.\")); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
背景：
动态图下目前使用到未实现的高阶算子，框架目前没有对这种情况进行处理，导致后续运算结果出现错误。
修复：
在自动代码生成部分，为使用到的未实现的高阶算子添加相应的报错信息。
拿matmul四阶举例，新增的报错信息如下：
"The Op matmul_triple_grad doesn't have any grad op. If you don't intend calculating higher order derivatives, please set create_graph to False."