[CustomDevice] GetCCLComm add custom device support #47168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronny1996
force-pushed
the
custom_device_ccl
branch
15 times, most recently
from
21a2f80
to
77e9d11
Compare
ronny1996
force-pushed
the
custom_device_ccl
branch
from
77e9d11
to
35e3bc8
Compare
ronny1996
force-pushed
the
custom_device_ccl
branch
from
73e94ea
to
6607c72
Compare
LiYuRio
reviewed
Oct 26, 2022
| #include "paddle/fluid/distributed/collective/ProcessGroupCustom.h" | ||
| #endif | ||
|
|
||
| namespace phi { |
There was a problem hiding this comment.
在distributed下加phi的namespace这个操作有点奇怪，既然单独出来了，不能用distributed的namespace吗
There was a problem hiding this comment.
这个接口在 phi/kernel/sync_batch_norm_kernel.h以phi命名空间导出的，写到distributed对用户而言有点奇怪
There was a problem hiding this comment.
如果反过来，让phi/kernel/sync_batch_norm_kernel.h里调用collective下的这个方法呢
There was a problem hiding this comment.
collective的方法对外都是隐藏的，现在 GetCCLComm定义在 phi/kernel/sync_batch_norm_kernel.h，实现在 paddle/fluid/distributed/collective/CommUtils.cc
chenwhql
reviewed
Oct 28, 2022
| @@ -0,0 +1,65 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
这个文件也不适合放到phi/kernels目录下，建议移到backends目录下
LiYuRio
approved these changes
Oct 31, 2022
chenwhql
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
GetCCLComm add custom device support