Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add communication strategy group #47021

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add communication strategy group #47021

merged 1 commit into from
Oct 18, 2022

Conversation

LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Oct 14, 2022

PR types

New features

PR changes

Others

Describe

Implement hybrid communication strategy

@paddle-bot
Copy link

paddle-bot bot commented Oct 14, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@LiYuRio LiYuRio force-pushed the dev_topo_strategy branch 2 times, most recently from 850319b to be5cffe Compare October 14, 2022 09:02
haohongxiang
haohongxiang approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@haohongxiang haohongxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for MoE

ForFishes
ForFishes approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for
set_tests_properties(test_strategy_group PROPERTIES TIMEOUT "120")

ForFishes
ForFishes approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit 178d7e5 into PaddlePaddle:develop Oct 18, 2022
@LiYuRio LiYuRio deleted the dev_topo_strategy branch October 19, 2022 01:36
haohongxiang pushed a commit to haohongxiang/Paddle that referenced this pull request Apr 7, 2023
@LiYuRio @haohongxiang
add strategy group (PaddlePaddle#47021)
7f2b45b
@haohongxiang haohongxiang mentioned this pull request Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haohongxiang haohongxiang haohongxiang approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiYuRio @ForFishes @XieYunshen @haohongxiang