fix build warning: [Wsign-compare] on linux #46644

Li-fAngyU · 2022-09-29T07:51:48Z

PR types

Others

PR changes

Others

Describe

fix build warning: [Wsign-compare] on linux

compiler_warning tracking issue: [CodeStyle] Compiler Warning tracking issue #47143

paddle-bot · 2022-09-29T07:51:53Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Li-fAngyU · 2022-09-30T02:53:52Z

@luotao1 针对 reinterpret_cast<uint64_t *>(...) 无法将 type "const char *" 转化成 type "uint64_t *" 这个问题(CI-GpuPS Error)，我去查了一些资料，可以利用 const_cast 去除 const 限制，然后就可以利用 reinterpret_cast 进行类型转换了。

请问有更好的方式吗？

注：原本是直接使用 (uint64_t *)(...) 强制转换。

luotao1 · 2022-09-30T03:34:09Z

可以利用 const_cast 去除 const 限制，然后就可以利用 reinterpret_cast 进行类型转换了。

const_cast 也是慎用。CI-GpuPS Error 不进行reinterpret_cast<uint64_t *>(...)会报错么？我看目前还有-Wunused-variable的错误。

luotao1 · 2022-09-30T03:32:03Z

paddle/fluid/distributed/ps/table/common_graph_table.cc

@@ -78,7 +78,7 @@ paddle::framework::GpuPsCommGraphFea GraphTable::make_gpu_ps_graph_fea(
        paddle::framework::GpuPsFeaInfo x;
        std::vector<uint64_t> feature_ids;
        for (size_t j = 0; j < bags[i].size(); j++) {
-          // TODO use FEATURE_TABLE instead
+          // TODO(danleifeng): Stuff. use FEATURE_TABLE instead


Stuff. 可以去掉

luotao1 · 2022-09-30T03:34:36Z

paddle/fluid/distributed/ps/table/memory_sparse_table.cc

@@ -996,31 +996,31 @@ int32_t MemorySparseTable::PushSparse(const uint64_t* keys,
         update_value_col,
         values,
         &task_keys]() -> int {
-          auto& keys = task_keys[shard_id];
-          auto& local_shard = _local_shards[shard_id];
+          auto &keys = task_keys[shard_id];


这些 & 和 * 的修改是格式化工具自动修改的么？

luotao1 · 2022-09-30T03:46:50Z

paddle/fluid/distributed/ps/table/common_graph_table.cc

@@ -254,7 +255,8 @@ char *GraphTable::random_sample_neighbor_from_ssd(
               ch,
               sizeof(int) * 2 + sizeof(uint64_t),
               str) == 0) {
-    uint64_t *data = ((uint64_t *)str.c_str());
+    uint64_t *data =
+        reinterpret_cast<uint64_t *>(const_cast<char *>(str.c_str()));


Wsign-compare，会对这段报warning么？是不是precommit的时候报的warning？因为distributed目录下很多没有做代码格式化，如果碰到，可以加 // NOLINT 先豁免本行。这个PR主要修Wsign-compare，其他内容可以不修。

Li-fAngyU · 2022-09-30T07:03:29Z

可以利用 const_cast 去除 const 限制，然后就可以利用 reinterpret_cast 进行类型转换了。

const_cast 也是慎用。CI-GpuPS Error 不进行reinterpret_cast<uint64_t *>(...)会报错么？我看目前还有-Wunused-variable的错误。

对的还有 Wunused-variable 的Warning。

zhiqiu · 2022-10-13T12:30:03Z

paddle/fluid/distributed/ps/table/sparse_sgd_rule.cc

                                            bool zero_init) {
-  for (int i = 0; i < _embedding_dim; ++i) {
+  for (int i = 0; i < static_cast<int>(_embedding_dim); ++i) {


Suggested change

for (int i = 0; i < static_cast<int>(_embedding_dim); ++i) {

for (size_t i = 0; i < _embedding_dim; ++i) {

Same for others.

zhiqiu · 2022-10-13T12:34:26Z

paddle/fluid/distributed/ps/table/common_graph_table.cc

@@ -177,7 +177,7 @@ paddle::framework::GpuPsCommGraph GraphTable::make_gpu_ps_graph(
      }));
    }
  }
-  for (int i = 0; i < (int)tasks.size(); i++) tasks[i].get();
+  for (int i = 0; i < static_cast<int>(tasks.size()); i++) tasks[i].get();


Suggested change

for (int i = 0; i < static_cast<int>(tasks.size()); i++) tasks[i].get();

for (size_t i = 0; i < tasks.size(); i++) tasks[i].get();

zhiqiu · 2022-10-13T12:34:50Z

paddle/fluid/distributed/ps/table/common_graph_table.cc

@@ -120,7 +120,7 @@ paddle::framework::GpuPsCommGraphFea GraphTable::make_gpu_ps_graph_fea(
  res.init_on_cpu(tot_len, (unsigned int)node_ids.size(), slot_num);
  unsigned int offset = 0, ind = 0;
  for (int i = 0; i < task_pool_size_; i++) {
-    for (int j = 0; j < (int)node_id_array[i].size(); j++) {
+    for (int j = 0; j < static_cast<int>(node_id_array[i].size()); j++) {


Suggested change

for (int j = 0; j < static_cast<int>(node_id_array[i].size()); j++) {

for (size_t j = 0; j < node_id_array[i].size(); j++) {

zhiqiu

LGTM

luotao1 · 2022-10-18T09:58:22Z

请根据代码风格检查指南修复下CodeStyle流水线

Li-fAngyU and others added 2 commits September 29, 2022 07:33

fix sign-compare warning.

36db826

Merge branch 'PaddlePaddle:develop' into develop

f84a341

paddle-bot bot added contributor External developers status: proposed labels Sep 29, 2022

Li-fAngyU added 5 commits September 29, 2022 18:31

Merge branch 'PaddlePaddle:develop' into develop

695ea6c

fix rand_r() error.

62764e4

fix sign-compare on GpuPS

7555df6

fix type cast error in common_graph_table.cc

b1583f5

Merge branch 'PaddlePaddle:develop' into develop

56f8aa6

luotao1 self-assigned this Sep 30, 2022

luotao1 reviewed Sep 30, 2022

View reviewed changes

luotao1 requested a review from zhiqiu October 13, 2022 11:59

zhiqiu reviewed Oct 13, 2022

View reviewed changes

Li-fAngyU and others added 3 commits October 14, 2022 15:04

Merge branch 'PaddlePaddle:develop' into develop

a19ac31

fix Wsign-warning

46827d4

fix code style

0ff825d

zhiqiu previously approved these changes Oct 18, 2022

View reviewed changes

luotao1 mentioned this pull request Oct 18, 2022

Fix build errors with gcc-11 #46808

Merged

Li-fAngyU and others added 2 commits October 18, 2022 20:56

Merge branch 'PaddlePaddle:develop' into develop

76ee430

fix code style

726deb7

Li-fAngyU dismissed zhiqiu’s stale review via 726deb7 October 18, 2022 13:07

fix code style--1

ddb04f9

Li-fAngyU requested review from zhiqiu and removed request for zhiqiu October 19, 2022 01:49

Li-fAngyU requested review from luotao1 and zhiqiu and removed request for luotao1 October 19, 2022 01:49

luotao1 approved these changes Oct 19, 2022

View reviewed changes

luotao1 merged commit be273ea into PaddlePaddle:develop Oct 19, 2022

Li-fAngyU mentioned this pull request Oct 19, 2022

[CodeStyle] Compiler Warning tracking issue #47143

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix build warning: [Wsign-compare] on linux #46644

fix build warning: [Wsign-compare] on linux #46644

Li-fAngyU commented Sep 29, 2022 •

edited by zhiqiu

Loading

paddle-bot bot commented Sep 29, 2022

Li-fAngyU commented Sep 30, 2022

luotao1 commented Sep 30, 2022

luotao1 Sep 30, 2022

Li-fAngyU Sep 30, 2022

luotao1 Sep 30, 2022

Li-fAngyU Sep 30, 2022

luotao1 Sep 30, 2022

Li-fAngyU commented Sep 30, 2022

zhiqiu Oct 13, 2022

zhiqiu Oct 13, 2022

zhiqiu Oct 13, 2022

zhiqiu left a comment

luotao1 commented Oct 18, 2022

	for (int i = 0; i < static_cast<int>(_embedding_dim); ++i) {
	for (size_t i = 0; i < _embedding_dim; ++i) {

	for (int i = 0; i < static_cast<int>(tasks.size()); i++) tasks[i].get();
	for (size_t i = 0; i < tasks.size(); i++) tasks[i].get();

	for (int j = 0; j < static_cast<int>(node_id_array[i].size()); j++) {
	for (size_t j = 0; j < node_id_array[i].size(); j++) {

fix build warning: [Wsign-compare] on linux #46644

fix build warning: [Wsign-compare] on linux #46644

Conversation

Li-fAngyU commented Sep 29, 2022 • edited by zhiqiu Loading

PR types

PR changes

Describe

paddle-bot bot commented Sep 29, 2022

Li-fAngyU commented Sep 30, 2022

luotao1 commented Sep 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Li-fAngyU commented Sep 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhiqiu left a comment

Choose a reason for hiding this comment

luotao1 commented Oct 18, 2022

Li-fAngyU commented Sep 29, 2022 •

edited by zhiqiu

Loading