Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hackathon No.18] 为 Paddle 新增 frexp API #46401

Merged
merged 18 commits into from
Sep 29, 2022
Merged

[Hackathon No.18] 为 Paddle 新增 frexp API #46401

merged 18 commits into from
Sep 29, 2022

Conversation

Zheng-Bicheng
Copy link
Contributor

@Zheng-Bicheng Zheng-Bicheng commented Sep 22, 2022 •
edited by SigureMo
Loading

PR types

New features

PR changes

APIs

Describe

新增frexp的代码

@paddle-bot
Copy link

paddle-bot bot commented Sep 22, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 22, 2022
@Zheng-Bicheng
Copy link
Contributor Author

PaddlePaddle/community#214

SigureMo
SigureMo requested changes Sep 22, 2022
View reviewed changes
python/paddle/__init__.py Outdated Show resolved Hide resolved
@Zheng-Bicheng Zheng-Bicheng changed the title [Hackathon No.80] 为 Paddle 新增 frexp API [Hackathon No.18] 为 Paddle 新增 frexp API Sep 22, 2022
@SigureMo SigureMo self-assigned this Sep 22, 2022
@SigureMo SigureMo mentioned this pull request Sep 22, 2022
Merged
SigureMo
SigureMo requested changes Sep 22, 2022
View reviewed changes
python/paddle/fluid/tests/unittests/test_frexp_api.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_frexp_api.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_frexp_api.py Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/__init__.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_frexp_api.py Outdated Show resolved Hide resolved
SigureMo
SigureMo requested changes Sep 22, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂时没有其他问题了，等 CI 看看有没有问题

python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_frexp_api.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/fluid/tests/unittests/test_frexp_api.py Outdated Show resolved Hide resolved
Zheng-Bicheng
Zheng-Bicheng commented Sep 22, 2022
View reviewed changes
Copy link
Contributor Author

@Zheng-Bicheng Zheng-Bicheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还差一个等梦柳看看

@Ligoml
Copy link
Contributor

Ligoml commented Sep 23, 2022

来了来了，我构建个预览康康

@SigureMo
Copy link
Member

image

示例代码出错了，貌似是数据类型问题，需要调整一下～

@Zheng-Bicheng
Copy link
Contributor Author

image

示例代码出错了，貌似是数据类型问题，需要调整一下～

image

示例代码出错了，貌似是数据类型问题，需要调整一下～

调整了，我重新过一下CI看看

@Ligoml Ligoml mentioned this pull request Sep 23, 2022
Closed
Ligoml
Ligoml reviewed Sep 26, 2022
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
Ligoml
Ligoml previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@Zheng-Bicheng
Copy link
Contributor Author

@tizhou86 大佬，能merge了吗

SigureMo
SigureMo previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs and codestyle (๑>؂<๑）

有几个流水线挂掉了，试试直接 re-run 下 re-run 得还挺快

@Ligoml
Copy link
Contributor

Ligoml commented Sep 26, 2022

@tizhou86 大佬，能merge了吗

需要等 @jeff41404 最后确认一下哈

@Zheng-Bicheng Zheng-Bicheng dismissed stale reviews from SigureMo and Ligoml via 2de0092 September 26, 2022 14:10
@luotao1 luotao1 mentioned this pull request Sep 27, 2022
Merged
@Zheng-Bicheng
Copy link
Contributor Author

@jeff41404 大佬麻烦再帮忙审核下

jeff41404
jeff41404 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 reopened this Sep 29, 2022
Ligoml
Ligoml approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@Ligoml Ligoml merged commit 1e2af54 into PaddlePaddle:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

@SigureMo SigureMo SigureMo left review comments

Assignees

@tizhou86 tizhou86

@luotao1 luotao1

@SigureMo SigureMo

@Ligoml Ligoml

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Zheng-Bicheng @Ligoml @SigureMo @jeff41404 @tizhou86 @luotao1