-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle] add pre-commit hook remove-tabs
for python files
#46290
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6f1f5e0
[CodeStyle] add pre-commit hook `remove-tabs` for python files
SigureMo 4145030
exclude files from thirdparty and unittest required tabs
SigureMo 3ee8a15
empty commit, test=document_fix
SigureMo 91fbc2f
Merge branch 'develop' into tabs/config/py
SigureMo 469bd7c
empty commit, test=document_fix
SigureMo 1343f2d
Merge branch 'develop' into tabs/config/py
SigureMo 99775d4
remove W191 and E101 in .flake8
SigureMo 7df65ba
empty commit, test=document_fix
SigureMo c6ce328
exclude fluid/ in flake8 config
SigureMo f4807a0
add comment
SigureMo f694c03
empty commit, test=document_fix
SigureMo aef8fdf
remove E124 and F404
SigureMo 3b51a96
empty commit, test=document_fix
SigureMo 5da1589
Merge branch 'develop' into tabs/config/py
SigureMo b9825a5
add comment
SigureMo 02380df
add comment
SigureMo 2bf08b2
empty commit, test=document_fix
SigureMo ed17d0f
update regex
SigureMo 7d39482
empty commit, test=document_fix
SigureMo b98a5bf
fix glob
SigureMo 5d08226
empty commit, test=document_fix
SigureMo 9e87dc1
remove some error code
SigureMo daf98d8
empty commit, test=document_fix
SigureMo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,30 @@ | ||
[flake8] | ||
select = C,E,F,W | ||
exclude = ./build | ||
exclude = | ||
./build, | ||
# A trick to exclude fluid/ but keep fluid/tests/, see more at | ||
# https://github.com/PaddlePaddle/Paddle/pull/46290#discussion_r976392010 | ||
./python/paddle/fluid/[!t]**, | ||
./python/paddle/fluid/tra** | ||
ignore = | ||
# E, see https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes | ||
E101,E121,E122,E123,E124,E125,E126,E127,E128,E129,E131, | ||
E201,E202,E203,E221,E225,E226,E228,E231,E241,E251,E261,E262,E265,E266,E271,E272,E275, | ||
E121,E122,E123,E125,E126,E127,E128,E129,E131, | ||
E201,E202,E203,E225,E226,E228,E231,E241,E251,E261,E262,E265,E266,E271,E272, | ||
E301,E302,E303,E305,E306, | ||
E401,E402, | ||
E501,E502, | ||
E701,E711,E712,E713,E714,E721,E722,E731,E741, | ||
|
||
# F, see https://flake8.pycqa.org/en/latest/user/error-codes.html | ||
F401,F402,F403,F404,F405, | ||
F522,F523,F524,F541, | ||
F401,F402,F403,F405, | ||
F522,F524,F541, | ||
F601,F631,F632, | ||
F811,F821,F823,F841, | ||
F811,F821,F841, | ||
|
||
# W, see https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes | ||
W191, | ||
W503,W504 | ||
W601,W605 | ||
per-file-ignores = | ||
# These files need tabs for testing. | ||
python/paddle/fluid/tests/unittests/dygraph_to_static/test_error.py:E101,W191 | ||
python/paddle/fluid/tests/unittests/collective/fleet/test_hdfs1.py:E101,W191 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E124 和 F404 是原本不存在的问题,统计出错是因为 #46014 (comment) 统计时候包含了 autopep8 产生的增量,因此这里把这俩也删掉了
此前现存问题应该是 68 个,已在 tracking issue 中更新
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
根据最新统计,又移除了 E221、E275、F523、F823,部分应该是由于排除掉了 fluid,另外一部分应该是因为 #46410 移除了部分 disable 掉的格式化,重新格式化后部分错误码消失了
之后在 tracking issue 更新