【Hackathon No.8】 add gumbel distribution api #46255

PureNatural · 2022-09-19T13:40:11Z

PR types

New features

PR changes

APIs

Describe

新增gumbel分布API
设计文档：PaddlePaddle/community#254
中文api文档：PaddlePaddle/docs#5290

paddle-bot · 2022-09-19T13:40:16Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot · 2022-09-19T13:40:19Z

✅ This PR's description meets the template requirements!
Please wait for other CI results.

dasenCoding · 2022-09-26T06:38:12Z

@cxxly 麻烦您 review 一下。

cxxly · 2022-09-26T13:33:00Z

处理CI失败问题，原则所有CI通过，才允许request review

cxxly · 2022-09-26T13:36:01Z

python/paddle/distribution/gumbel.py

+from paddle.distribution.uniform import Uniform
+from paddle.distribution.transformed_distribution import TransformedDistribution
+from paddle.distribution.transform import AffineTransform, ExpTransform
+from paddle.fluid import framework as framework


参考google style组织包的结构 https://google.github.io/styleguide/pyguide.html#s3.13-imports-formatting

cxxly · 2022-09-26T13:38:17Z

python/paddle/distribution/gumbel.py

+    Args:
+        loc(int|float): The mean of normal distribution.The data type is int, float.
+        scale(int|float): The std of normal distribution.The data type is int, float.
+


int|float|Tensor，Tensor为必须支持数据类型

cxxly · 2022-09-26T13:38:52Z

python/paddle/distribution/gumbel.py

+    Args:
+        loc(int|float): The mean of normal distribution.The data type is int, float.
+        scale(int|float): The std of normal distribution.The data type is int, float.
+


The location parameter of gumbel distribution .....

cxxly · 2022-09-26T13:39:28Z

python/paddle/distribution/gumbel.py

+          from paddle.distribution import Gumbel
+
+          # Define a single scalar Gumbel distribution.
+          dist = Gumbel(loc=0., scale=1.)


示例代码中增加一些方法调用示例

cxxly · 2022-09-26T13:40:51Z

python/paddle/distribution/gumbel.py

+                f"Expected type of scale is Real|Variable, but got {type(scale)}"
+            )
+        self.loc, self.scale = paddle.broadcast_tensors([loc, scale])
+        finfo = np.finfo(type(self.loc))


如果输入类型是 Real, 此处broadcast会报错

cxxly · 2022-09-26T13:42:53Z

python/paddle/distribution/gumbel.py

+                f"Expected type of scale is Real|Variable, but got {type(scale)}"
+            )
+        self.loc, self.scale = paddle.broadcast_tensors([loc, scale])
+        finfo = np.finfo(type(self.loc))


如果 loc为Variable，此处np.finfo(type(self.loc))会报错

cxxly · 2022-09-26T13:45:52Z

python/paddle/distribution/gumbel.py

+            Tensor: The variance value.
+
+        """
+        return math.pow(self.scale, 2) * math.pow(math.pi, 2) / 6


使用Paddle API运算，math.pow不支持Tensor类型

cxxly · 2022-09-26T13:46:04Z

python/paddle/distribution/gumbel.py

+        """Mean of distribution
+
+        The variance is
+


The mean is ...

cxxly · 2022-09-26T13:46:48Z

python/paddle/distribution/gumbel.py

+            Tensor: std value.
+
+        """
+        return math.sqrt(self.variance)


cxxly · 2022-09-26T13:46:54Z

python/paddle/distribution/gumbel.py

+
+        """
+        y = (self.loc - value) / self.scale
+        return math.exp(y - math.exp(y)) / self.scale


cxxly · 2022-09-26T13:47:03Z

python/paddle/distribution/gumbel.py

+          Tensor: log probability.The data type is same with value.
+
+        """
+        return math.log(self.prob(value))


cxxly · 2022-09-26T13:47:12Z

python/paddle/distribution/gumbel.py

+          Tensor: Shannon entropy of gumbel distribution.
+
+        """
+        return math.log(self.scale) + 1 + np.euler_gamma


非常感谢您的审查意见！我们会逐一修改完善。

cxxly · 2022-09-26T13:50:17Z

增加动态图/静态图下相关测试用例

dasenCoding · 2022-10-13T01:26:28Z

@cxxly 您好，针对上次您提出的review意见我们已经修改，劳烦再次审查一下。

cxxly

LGTM

Ligoml

LGTM for docs

jeff41404 · 2022-10-14T01:43:59Z

python/paddle/distribution/gumbel.py

+          from paddle.distribution.gumbel import Gumbel
+
+          # Gumbel distributed with loc=0, scale=1
+          dist = Gumbel(paddle.full([0.0]), paddle.full([1.0]))


paddle.full([0.0]) will report error? use paddle.to_tensor(0.0) or paddle.full([1], 0.0) instead?

paddle.full([1.0]) is also needed to correct.

jeff41404 · 2022-10-14T01:46:17Z

python/paddle/distribution/gumbel.py

+          dist = Gumbel(paddle.full([0.0]), paddle.full([1.0]))
+          dist.sample()
+          # Tensor(shape=[1], dtype=float32, place=Place(gpu:0), stop_gradient=True, [4.14814520])
+          value = paddle.full([0.5])


use paddle.to_tensor(0.5) or paddle.full([1], 0.5) or instead?

jeff41404 · 2022-10-14T01:56:23Z

python/paddle/distribution/gumbel.py

+        """
+        return paddle.log(self.prob(value))
+
+    def cdf(self, value):


in order to have rfc same with code, need to add this functioncdf in rfc API 实现方案

…l_api

PureNatural · 2022-10-14T03:51:53Z

According to your comments, we have fixed parameters and add cdf function in rfc(PaddlePaddle/community#298). Would you please review again ?@jeff41404 .Thanks.

jeff41404 · 2022-10-14T07:04:10Z

According to your comments, we have fixed parameters and add cdf function in rfc(PaddlePaddle/community#298). Would you please review again ?@jeff41404 .Thanks.
reviewed, thanks!

PureNatural · 2022-10-14T08:26:07Z

Sorry about that mistake. We have fixed that. Would you please review again ?@jeff41404 .Thanks.

Ligoml

LGTM for docs
copyright随后再改吧

Ligoml · 2022-10-14T10:28:57Z

python/paddle/distribution/gumbel.py

@@ -0,0 +1,242 @@
+# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.


Suggested change

# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.

# Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

好的，我们随后会跟进修改

@Ligoml 您好，我们对copyright也进行了修改，麻烦您再review一下，非常感谢。

jeff41404

LGTM

Ligoml

LGTM

Ligoml

LGTM

PureNatural and others added 3 commits September 18, 2022 14:08

init gumbel api

d4263c2

commit: update test file

a29f111

fix：bug

f5d62e1

paddle-bot bot added contributor External developers status: proposed labels Sep 19, 2022

PureNatural mentioned this pull request Sep 19, 2022

【PaddlePaddle Hackathon 第三期】任务总览 #43938

Closed

luotao1 assigned luotao1, cxxly and Ligoml Sep 20, 2022

cxxly reviewed Sep 26, 2022

View reviewed changes

dasenCoding and others added 4 commits September 28, 2022 17:01

update Gumbel API

0b8faec

upgrade distribution/gumbel.py

e6a8c1b

add tests/test_distribution_gumbel.py

2791493

Merge branch 'PaddlePaddle:develop' into gumbel_api

1541ecb

PureNatural added 2 commits October 13, 2022 01:21

fix：code style

444454e

fix：code style

3598ed5

cxxly previously approved these changes Oct 13, 2022

View reviewed changes

Ligoml previously approved these changes Oct 13, 2022

View reviewed changes

jeff41404 reviewed Oct 14, 2022

View reviewed changes

PureNatural added 3 commits October 14, 2022 10:38

Merge branch 'PaddlePaddle:develop' into gumbel_api

017f66c

fix：en doc

e7108f0

Merge branch 'gumbel_api' of github.com:PureNatural/Paddle into gumbe…

069cadf

…l_api

PureNatural dismissed stale reviews from Ligoml and cxxly via 069cadf October 14, 2022 02:41

PureNatural mentioned this pull request Oct 14, 2022

add cdf function for gumbel PaddlePaddle/community#298

Merged

fix：param

e93ff40

Ligoml previously approved these changes Oct 14, 2022

View reviewed changes

fix：copyright

6172d98

PureNatural dismissed Ligoml’s stale review via 6172d98 October 16, 2022 02:43

jeff41404 previously approved these changes Oct 17, 2022

View reviewed changes

Ligoml previously approved these changes Oct 17, 2022

View reviewed changes

fixSample; test=document_fix

c957ab4

dasenCoding dismissed stale reviews from Ligoml and jeff41404 via c957ab4 October 17, 2022 08:50

Ligoml approved these changes Oct 17, 2022

View reviewed changes

jeff41404 approved these changes Oct 17, 2022

View reviewed changes

Ligoml merged commit f1a9f87 into PaddlePaddle:develop Oct 17, 2022

PureNatural deleted the gumbel_api branch October 17, 2022 10:50

		@@ -0,0 +1,242 @@
		# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.

	# Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved.
	# Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.

【Hackathon No.8】 add gumbel distribution api #46255

【Hackathon No.8】 add gumbel distribution api #46255

Conversation

PureNatural commented Sep 19, 2022 • edited Loading

PR types

PR changes

Describe

paddle-bot bot commented Sep 19, 2022

paddle-bot bot commented Sep 19, 2022 • edited Loading

dasenCoding commented Sep 26, 2022

cxxly commented Sep 26, 2022

Choose a reason for hiding this comment

cxxly Sep 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cxxly commented Sep 26, 2022

dasenCoding commented Oct 13, 2022

cxxly left a comment

Choose a reason for hiding this comment

Ligoml left a comment

Choose a reason for hiding this comment

jeff41404 Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 Oct 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PureNatural commented Oct 14, 2022

jeff41404 commented Oct 14, 2022

PureNatural commented Oct 14, 2022

Ligoml left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

Ligoml left a comment

Choose a reason for hiding this comment

Ligoml left a comment

Choose a reason for hiding this comment

PureNatural commented Sep 19, 2022 •

edited

Loading

paddle-bot bot commented Sep 19, 2022 •

edited

Loading

cxxly Sep 26, 2022 •

edited

Loading

jeff41404 Oct 14, 2022 •

edited

Loading

jeff41404 Oct 14, 2022 •

edited

Loading