Gloo update #45584
Merged
Gloo update #45584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhang533
requested changes
Aug 31, 2022
gongweibao
requested changes
Sep 2, 2022
| @@ -25,8 +25,8 @@ set(GLOO_LIBRARY_DIR | |||
| "${GLOO_INSTALL_DIR}/lib" | |||
| CACHE PATH "gloo library directory." FORCE) | |||
| # As we add extra features for gloo, we use the non-official repo | |||
| set(GLOO_REPOSITORY ${GIT_URL}/sandyhouse/gloo.git) | |||
| set(GLOO_TAG v0.0.2) | |||
| set(GLOO_REPOSITORY ${GIT_URL}/ziyoujiyi/gloo.git) | |||
There was a problem hiding this comment.
Why we don't use the original branch of gloo?
There was a problem hiding this comment.
当前框架使用的gloo版本从 2020.1.9 commit345 拉过来的，然后新增了自定义功能，共 8 个 commit，涉及改动文件数20+，代码行数 1000+，落后官方 repo 53 个 commit，使用官方 repo 工作量估计是一个月，之前讨论的方案是先临时修复
fuyinno4
approved these changes
Sep 5, 2022
jzhang533
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
期待使用upstream gloo
@raindrops2sea @XiaoguangHu01 我们需要对paddle仓库里对第三方依赖的使用做一次治理。
如果看看./cmake/external下的文件，不仅存在使用非upstream仓库的问题，甚至存在依赖binary的问题。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
solve gcc 9.3 gloo compile error
modify: ziyoujiyi/gloo@8b6b61d