Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make inference_c test linking only paddle_inference_c #44126

Merged
merged 1 commit into from
Jul 6, 2022
Merged

make inference_c test linking only paddle_inference_c #44126

merged 1 commit into from
Jul 6, 2022

Conversation

betterpig
Copy link
Contributor

@betterpig betterpig commented Jul 6, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

See the original PR #41944 #43936, after these 2 PR merged, the code becomes complicated and paddle_inference_c_shared build but not used in linux. So make inference_c test linking only paddle_inference_c.

  • the paddle_inference_shared is not needed since paddle_inference_c already depend paddle_inference
  • make 8 c_api test still compile with static library so that we needn's compile paddle_inference_c_shared when ON_INFER=OFF
  • Since only 8 test compiling method were restored, the optimization effect described in PR make inference_api_test compile with dynamic linking library #41944 has not been influenced almost, the linking time of C++ test in paddle\fluid\inference\tests\api is still 10 second around.

zhwesky2010
zhwesky2010 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betterpig betterpig merged commit bbe9955 into PaddlePaddle:develop Jul 6, 2022
@betterpig betterpig deleted the c_shared branch July 7, 2022 03:32
@tianshuo78520a tianshuo78520a mentioned this pull request Jul 7, 2022
Merged
luotao1 pushed a commit that referenced this pull request Jul 7, 2022
@tianshuo78520a
Revert "make inference_c test linking only paddle_inference_c (#44126)…
9428c96 
…" (#44149)

This reverts commit bbe9955.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@betterpig @zhwesky2010