Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm serial mode in exclusive case #43073

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

lelelelelez
Copy link
Contributor

@lelelelelez lelelelelez commented May 29, 2022

PR types

Others

PR changes

Others

Describe

在制定单测并发策略的时候,发现有一些case即使设定了并发度,仍无法并发(多见于独占case)。在分析这些case时,发现它们均设定了RUN_SERIVAL = 1表明其必须独占。而在真实的实验中,这些case并不是非要独占执行,以一定的并发度执行仍然可以执行成功。
因此,此PR将RUN_SERIVAL = 1去掉,收益为coverage的独占case由原先3000s左右可以降到1000s左右,同时全量case的执行时间由7500s降到5200s左右,如下图。
image
此PR未改变原并发度,因此单测timeout的个数仍很多,retry时间也达到了1000s左右,下个PR会解决该问题。
同时,下个PR会增加SERIVAL的approve规则。

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lelelelelez lelelelelez merged commit a1d8777 into PaddlePaddle:develop May 30, 2022
@lelelelelez lelelelelez deleted the serial branch May 30, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants