[Yaml] Modify api and add unittests for full api final state. #41437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
reviewed
Apr 6, 2022
python/paddle/fluid/layers/tensor.py
Outdated
| shape = utils.convert_shape_to_list(shape) | ||
| if not isinstance(dtype, core.VarDesc.VarType): | ||
| dtype = convert_np_dtype_to_dtype_(dtype) | ||
| assert out is None, "Final State mode don't support out is None." |
There was a problem hiding this comment.
是不是out为None，让跑老动态图比较好，至少不会挂
Aurelius84
reviewed
Apr 7, 2022
| @@ -1170,6 +1168,9 @@ def _remove_if_exist(*dicts): | |||
| if name not in self._buffers: | |||
| self._non_persistable_buffer_names_set.add(name) | |||
| _buffers[name] = value | |||
| if not _buffers[name].name: | |||
| _buffers[name].name = unique_name.generate( | |||
| '_generated_var') | |||
There was a problem hiding this comment.
Suggested change
| '_generated_var') | |
| if not value.name: | |
| value.name = unique_name.generate( '_buffers_'+name) |
Aurelius84
approved these changes
Apr 10, 2022
douch
pushed a commit
to douch/Paddle
that referenced
this pull request
Apr 10, 2022
…Paddle#41437) * full api fix * when out is None, go old dygraph mode * fix * add name for buffer * fix by code review * fix * by static check
2742195759
added a commit
to 2742195759/Paddle
that referenced
this pull request
Apr 11, 2022
…Paddle#41437) * full api fix * when out is None, go old dygraph mode * fix * add name for buffer * fix by code review * fix * by static check
phlrain
pushed a commit
that referenced
this pull request
Apr 11, 2022
#41618) * full api fix * when out is None, go old dygraph mode * fix * add name for buffer * fix by code review * fix * by static check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
modify api and add unittests for full api final state.