-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi] Unify kernel build targets #41091
[Phi] Unify kernel build targets #41091
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for xpu_kp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Function optimization
PR changes
Others
Describe
[Phi] Unify kernel build targets
尽可能减少phi kernel的编译单元,可能判断代码会有点冗余,但视情况合并编译target,可以在整体上有效减少xxx_library的调用次数,可以作为临时方案解决windows编译失败的问题
但是目前phi kernel仅迁移了不到一半的原fluid kernel,后续kernel迁移增多,target还是会继续增多,需要有针对此windows编译问题的解决预案,并且列入计划,比如拆分静态库,unity build等