Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pten] Migration of eigen numeric extensions and functors in paddle/fluid/operatos/eigen #39124

Merged
merged 4 commits into from
Jan 24, 2022
Merged

[Pten] Migration of eigen numeric extensions and functors in paddle/fluid/operatos/eigen #39124

merged 4 commits into from
Jan 24, 2022

Conversation

iclementine
Copy link

@iclementine iclementine commented Jan 21, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Migration of eigen numeric extensions and functors in paddle/fluid/operatos/eigen

  1. move "paddle/fluid/platform/eigen_ext.h" to "paddle/pten/kernels/funcs/eigen/extensions.h";
  2. update the include path of "move "paddle/fluid/platform/eigen_ext.h",
  3. move functors in "paddle/fluid/operatos/eigen" to "paddle/pten/kernels/funcs/eigen";

chenwhql
chenwhql approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark CI. 另外，当前PR虽然都是eigen相关代码改动，但相互之间并没有很大的依赖，建议后续工作分批提pr。

OP Benchmark CI情况说明：
image

CI最终因这4个测试fail：

  • sum_3、mean_3 forward没有eigen函数调用，只调用了pten::kernels::ReduceHigherDimKernel，当前PR不涉及到该函数的修改，因此判定为波动。

  • group_norm_0 (forward)，所有3个Kernel时间都增加10%，另外2个Kernel没有修改，因此判定为环境影响造成的波动。

    • develop
      image

    • 当前PR
      image

  • max_2 (backward)，2个Kernel时间均有增加，判定为环境造成的波动。

    • develop
      image

    • 当前PR
      image

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iclementine iclementine merged commit a1e40dc into PaddlePaddle:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@Xreki Xreki Xreki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iclementine @Xreki @chenwhql @XiaoguangHu01