[part 3]change type of function args #38887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
reviewed
Jan 12, 2022
| @@ -35,7 +35,7 @@ LOGICAL_BINARY_FUNCTOR(CudaXorFunctor, ^) | |||
| template <typename T> | |||
| struct CudaNotFunctor { | |||
| using ELEMENT_TYPE = T; | |||
| HOSTDEVICE bool operator()(const T* args) const { return !args[0]; } | |||
| HOSTDEVICE bool operator()(const T a) const { return !a; } | |||
| }; | |||
zhangting2020
force-pushed
the
elementwise_ops3
branch
from
75c98f7
to
b795e91
Compare
zhangting2020
force-pushed
the
elementwise_ops3
branch
from
b795e91
to
87e2dba
Compare
zhangting2020
force-pushed
the
elementwise_ops3
branch
from
87e2dba
to
72ed648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimizationPR changes
OPsDescribe
因 #38859 支持不同输入类型的elementwise op，需要修改计算函数的参数为值传递