-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ctc edit distance evaluator can not print information in v2 API. #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
force-pushed
the
fix_ctc_evaluator
branch
from
September 4, 2017 05:26
f2e32a0
to
5d20820
Compare
lcy-seso
force-pushed
the
fix_ctc_evaluator
branch
from
September 4, 2017 05:37
5d20820
to
faa4da4
Compare
lcy-seso
changed the title
fix ctc edit distance in v2 API.
fix ctc edit distance evaluator can not print information in v2 API.
Sep 4, 2017
qingqing01
reviewed
Sep 4, 2017
|
||
const std::string delimiter("."); | ||
std::string::size_type foundPos = name.find(delimiter, 0); | ||
CHECK(foundPos != std::string::npos); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
或许split好些,例如
https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/gserver/evaluators/Evaluator.cpp#L783, 然后取分割后的最后一个:
auto it = this->values_.find(buffers[buffers.size() - 1]);
避免name含有多个.
lcy-seso
force-pushed
the
fix_ctc_evaluator
branch
2 times, most recently
from
September 4, 2017 07:40
72db117
to
f30fa48
Compare
qingqing01
previously approved these changes
Sep 4, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
lcy-seso
force-pushed
the
fix_ctc_evaluator
branch
from
September 4, 2017 07:51
f30fa48
to
0b478e9
Compare
lcy-seso
force-pushed
the
fix_ctc_evaluator
branch
from
September 4, 2017 13:53
2cce058
to
a523bea
Compare
qingqing01
approved these changes
Sep 4, 2017
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
…Paddle#3844) * [dev] rbox update2 (PaddlePaddle#3828) * set lr for 4 card as default, and update * fix error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3802