Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize elementwise_min_grad using new reduce interface #38236

Merged
merged 24 commits into from
Jan 12, 2022

Conversation

AshburnLee
Copy link
Contributor

@AshburnLee AshburnLee commented Dec 17, 2021

PR types

Performance optimization

PR changes

OPs

Describe

功能

该PR使用Reduce接口优化了elementwise_min的反向计算

效果

以下是op-benchmark效果,其中「paddle优化1」 表示使用Reduce初步优化效果;「paddle优化2」表示进一步优化,即三元计算替换二元计算后的优化效果:

截屏2022-01-10 13 35 27

整体上,效果与elementwise_max_grad几乎相同:优化3(适配多输出代码优化后)较优化1(reduce接口优化)、优化2(三元functor优化)均有显著提升;但当前前两个配置差于dev 10%左右;

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

Sorry to inform you that 8d057d0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@paddle-bot-old
Copy link

Sorry to inform you that d068de7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PR-CI-OP-benchmark

@ZzSean ZzSean merged commit c2f825d into PaddlePaddle:develop Jan 12, 2022
@AshburnLee AshburnLee deleted the elem_min_grad_new branch January 12, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants