Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak problen of set_value op #38098

Merged
merged 4 commits into from
Dec 14, 2021
Merged

fix memory leak problen of set_value op #38098

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bec658
fix bug of set_value op
zyfncg Dec 13, 2021
f844fbe
fix BumpInplaceVersion
zyfncg Dec 14, 2021
b583e47
polish some comments
zyfncg Dec 14, 2021
7f5f481
revert change of full_like
zyfncg Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions paddle/fluid/pybind/imperative.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,11 @@ void BindImperative(py::module *m_ptr) {
}
};

// NOTE(liym27):
// Increase the version of VarBase self because __setitem__ is an
// inplace operator for the VarBase self.
self->BumpInplaceVersion();

// 1. Check argumnets
bool parse_index = true;

Expand Down Expand Up @@ -1137,10 +1142,6 @@ void BindImperative(py::module *m_ptr) {
SetTensorFromPyArray(self_tensor, self_numpy,
self_tensor->place(), false);
}
// NOTE(liym27):
// Increase the version of VarBase self because __setitem__ is an
// inplace operator for the VarBase self.
self->BumpInplaceVersion();
})
.def("_getitem_index_not_tensor",
[](std::shared_ptr<imperative::VarBase> &self, py::handle _index) {
Expand Down