Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup download uncompress function #37311

Merged
merged 6 commits into from
Nov 23, 2021

Conversation

CtfGo
Copy link
Contributor

@CtfGo CtfGo commented Nov 17, 2021

PR types

Function optimization

PR changes

Others

Describe

paddle.utils.download :change to call extractall on tar/zip compressd file to speed up the uncompress process when they includes many files

--- result of decompression speed comparison ---

  1. dataset:https://paddlenlp.bj.bcebos.com/datasets/cnn_dailymail/cnn_stories.tgz, decompression time
    :5m50s vs 20s
  2. dataset:https://paddlenlp.bj.bcebos.com/datasets/cnn_dailymail/dailymail_stories.tgz, decompression time:33m20s vs 47s

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 17, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 18, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 18, 2021
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 467099f into PaddlePaddle:develop Nov 23, 2021
@CtfGo CtfGo deleted the speedup_download_decompress branch November 23, 2021 07:45
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
`paddle.utils.download` :change to call `extractall` on tar/zip compressd file  to speed up the uncompress process when they includes many files

--- result of decompression speed comparison ---
1. dataset:https://paddlenlp.bj.bcebos.com/datasets/cnn_dailymail/cnn_stories.tgz, decompression time
:5m50s vs 20s
2. dataset:https://paddlenlp.bj.bcebos.com/datasets/cnn_dailymail/dailymail_stories.tgz, decompression time:33m20s vs 47s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants