fix potential tensor leak in tensor.__setitem__ #35013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
sneaxiy
reviewed
Aug 23, 2021
| create_test_value_numpy_fp32(TestSetValueItemSlice2) | ||
| create_test_value_numpy_fp32(TestSetValueItemSlice3) | ||
| create_test_value_numpy_fp32(TestSetValueItemSlice4) | ||
| # class TestSetValueItemSliceInWhile(TestSetValueApi): |
There was a problem hiding this comment.
Not the final version.
sneaxiy
reviewed
Aug 23, 2021
paddle/fluid/pybind/imperative.cc
Outdated
| if (PyTuple_Check(_index.ptr())) { | ||
| index_ptr = _index.ptr(); | ||
| } else { | ||
| index_ptr = PyTuple_New(1); |
There was a problem hiding this comment.
I am rather curious when the index_ptr would be released (when the reference count of index_ptr decreases to zero)? Is there any risk that index_ptr causes memory leak?
I have tested that index_ptr would really cause memory leak.
There was a problem hiding this comment.
Yes, it is another problem and I'm working on it .
sneaxiy
previously approved these changes
Aug 24, 2021
paddle/fluid/pybind/imperative.cc
Outdated
| PyObject *index = !PyTuple_Check(_index) ? PyTuple_Pack(1, _index) : _index; | ||
| DEFINE_PADDLE_SCOPE_GUARD([&index, &_index]() { |
There was a problem hiding this comment.
NIT. You can use [index, _index] here since index and _index are pointers.
| PyObject *index_ptr = !PyTuple_Check(_index.ptr()) | ||
| ? PyTuple_Pack(1, _index.ptr()) | ||
| : _index.ptr(); | ||
| DEFINE_PADDLE_SCOPE_GUARD([&index_ptr, &_index]() { | ||
| if (!PyTuple_Check(_index.ptr())) { |
sneaxiy
approved these changes
Aug 24, 2021
This was referenced Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
fix potential tensor leak in tensor.setitem. Expected to close #34752, #34868
see example below:
