-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inference prepare data bug #33305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge paddle
merge paddle develop
merge paddle develop
merge develop
Thanks for your contribution! |
Shixiaowei02
reviewed
Jun 2, 2021
shangzhizhou
previously approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shangzhizhou
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shixiaowei02
approved these changes
Jun 4, 2021
b3602sss
added a commit
to b3602sss/Paddle
that referenced
this pull request
Jun 7, 2021
* fix inference prepare data bug * rename functions * typo * typo * typo * UT correct * correct condition * correct condition * ci coverage * morelines * fix ci coverage
b3602sss
added a commit
to b3602sss/Paddle
that referenced
this pull request
Jun 7, 2021
* fix inference prepare data bug * rename functions * typo * typo * typo * UT correct * correct condition * correct condition * ci coverage * morelines * fix ci coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
在推理时,如果条件分支之间产出的tensor在不同的device上,prepare data可能会因为某一个分支被开启,但是在另外一个分支上这个优化不适用。所以对于后续的OP强制关闭prepare data优化