Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inference prepare data bug #33305

Merged
merged 22 commits into from
Jun 4, 2021
Merged

Conversation

b3602sss
Copy link
Contributor

@b3602sss b3602sss commented Jun 2, 2021

PR types

Bug fixes

PR changes

OPs

Describe

在推理时,如果条件分支之间产出的tensor在不同的device上,prepare data可能会因为某一个分支被开启,但是在另外一个分支上这个优化不适用。所以对于后续的OP强制关闭prepare data优化

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@b3602sss b3602sss changed the title Develop3 fix inference prepare data bug Jun 2, 2021
shangzhizhou
shangzhizhou previously approved these changes Jun 3, 2021
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit dd18123 into PaddlePaddle:develop Jun 4, 2021
b3602sss added a commit to b3602sss/Paddle that referenced this pull request Jun 7, 2021
* fix inference prepare data bug

* rename functions

* typo

* typo

* typo

* UT correct

* correct condition

* correct condition

* ci coverage

* morelines

* fix ci coverage
b3602sss added a commit to b3602sss/Paddle that referenced this pull request Jun 7, 2021
* fix inference prepare data bug

* rename functions

* typo

* typo

* typo

* UT correct

* correct condition

* correct condition

* ci coverage

* morelines

* fix ci coverage
@b3602sss b3602sss deleted the develop3 branch June 17, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants