Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import sequence_* API to new namespace #32089

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

iclementine
Copy link

PR types

Others

PR changes

APIs

Describe

  1. import sequence_mask into `paddle.nn.functional', since it is a commonly used API in sequence modelding tasks;
  2. import sequence_* APIs (except for sequence_mask) into paddle.static.nn.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 6, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -97,6 +97,7 @@
# from .extension import temporal_shift #DEFINE_ALIAS
# from .extension import warpctc #DEFINE_ALIAS
from .extension import diag_embed #DEFINE_ALIAS
from .extension import sequence_mask #DEFINE_ALIASs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#DEFINE_ALIAS is no longer needed, also, a typo (s)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API搬家后,相应的docstring也麻烦更新一下。

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequence_mask是挪到paddle.nn.functional下的API,docstring里要统一下Tensor, LoDTensor, Variable这些概念吧。
其他的挪到paddle.static下的API感觉就那样吧。

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 21, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 21, 2021
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iclementine
Copy link
Author

图片

图片

@iclementine iclementine merged commit f12c943 into PaddlePaddle:develop Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants