-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import sequence_* API to new namespace #32089
Conversation
Thanks for your contribution! |
@@ -97,6 +97,7 @@ | |||
# from .extension import temporal_shift #DEFINE_ALIAS | |||
# from .extension import warpctc #DEFINE_ALIAS | |||
from .extension import diag_embed #DEFINE_ALIAS | |||
from .extension import sequence_mask #DEFINE_ALIASs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#DEFINE_ALIAS
is no longer needed, also, a typo (s
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @jzhang533 @XiaoguangHu01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API搬家后,相应的docstring也麻烦更新一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sequence_mask是挪到paddle.nn.functional
下的API,docstring里要统一下Tensor, LoDTensor, Variable这些概念吧。
其他的挪到paddle.static
下的API感觉就那样吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR types
Others
PR changes
APIs
Describe
sequence_mask
into `paddle.nn.functional', since it is a commonly used API in sequence modelding tasks;sequence_*
APIs (except for sequence_mask) intopaddle.static.nn
.