Add LayerDict class #31951
Merged
Add LayerDict class #31951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Mar 31, 2021
python/paddle/nn/layer/container.py
Outdated
| #relu : ReLU() | ||
|
|
||
| """ | ||
| for key, layer in sublayers.items(): |
There was a problem hiding this comment.
Do we need add checking for inputs?
There was a problem hiding this comment.
add the inputs checking
python/paddle/nn/layer/container.py
Outdated
| def __init__(self, sublayers=None): | ||
| super(LayerDict, self).__init__() | ||
| if sublayers is not None: | ||
| self._sub_layers.update(sublayers) |
There was a problem hiding this comment.
here need call self.update, and the input should be checked in update method, otherwise here also need to check input
MingMingShangTian
force-pushed
the
module_dict
branch
from
26a7c2a
to
be5af53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Add LayerDict to store the layers with its name.