Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REUPLOAD Added vanilla LSTM and LSTM with peepholes oneDNN fp32 kernel #30719

Merged
merged 26 commits into from
Jan 27, 2021
Merged

REUPLOAD Added vanilla LSTM and LSTM with peepholes oneDNN fp32 kernel #30719

merged 26 commits into from
Jan 27, 2021

Conversation

jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

This PR adds vanilla LSTM and LSTM with peepholes oneDNN kernel to PaddlePaddle. Currently only fp32 is supported, but bf16 and int8 will be added in future.

Jakub Piasecki and others added 24 commits December 2, 2020 14:40
added external reorder to profiler
1ecc4cf
resolving merge conflict
92db4d2
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
ac02826 
… develop
resolved conflict
cfc0a1d
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
9f3bed6 
… lstm_fp32
added enable_static
7ce32b3
initial version of lstm, not working yet
79a8e4e
added lstm to operators.cmake
985067f
added vanilla lstm mkldnn op
c3e0ccd
added peephole weights integration
7d61360
minor changes
2670631
added formatting
1f549fc
added fusion_lstm_mkldnn to static_whitelist
24f2bd7
added formatting
ac74650
removed comment
4ecf14c
moved use_peepholes attribute inside is_cached block
355c4e9
reverted wrong changes
05eaa27
minor formatting change
8df2930
@jakpiase
Merge branch 'develop' into lstm_float32
7a4932a
@jakpiase
minor changes
c29d108
changed stream handling
b26c6e8
resolved conflict
c05dccf
Merge branch 'develop' into lstm_fp32
740385e
minor change
d66a171
@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase changed the title Fp32lstm REUPLOAD Added vanilla LSTM and LSTM with peepholes oneDNN fp32 kernel Jan 26, 2021
@jakpiase
Copy link
Contributor Author

@jczaja I have done minor changes since last PR, could you please take a look?

@jczaja jczaja added the Intel label Jan 26, 2021
jczaja
jczaja approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Jan 26, 2021

@luotao1 This is resolved version of LSTM fp32 oneDNN PR that was reverted. Please review.

luotao1
luotao1 approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit f8da553 into PaddlePaddle:develop Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczaja jczaja jczaja approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@luotao1 luotao1

Labels
Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakpiase @jczaja @luotao1