add ROIPooling for Fast(er) R-CNN #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Aug 19, 2017
paddle/gserver/layers/ROIPoolLayer.h
Outdated
| size_t pooledHeight_; | ||
| real spatialScale_; | ||
|
|
||
| MatrixPtr maxIdxs_; |
There was a problem hiding this comment.
maxIdxs_ should be int matrix, but there is no int matrix in Paddle. So add comments here use the real matrix instead.
| @config_layer('roi_pool') | ||
| class ROIPoolLayer(LayerBase): | ||
| def __init__(self, name, inputs, pooled_width, pooled_height, | ||
| spatial_scale): |
There was a problem hiding this comment.
spatial_scale): -> spatial_scale, **xargs):
| class ROIPoolLayer(LayerBase): | ||
| def __init__(self, name, inputs, pooled_width, pooled_height, | ||
| spatial_scale): | ||
| super(ROIPoolLayer, self).__init__(name, 'roi_pool', 0, inputs) |
There was a problem hiding this comment.
inputs) - > inputs, **xargs):
| resetOutput(numROIs, channels_ * pooledHeight_ * pooledWidth_); | ||
| MatrixPtr outputValue = getOutputValue(); | ||
|
|
||
| if (useGpu_) { |
There was a problem hiding this comment.
Add TODO(xxx): implement on GPU later.
| bottomROIs += roiOffset; | ||
| } | ||
| if (useGpu_) { | ||
| getOutputValue()->copyFrom(*outputValue); |
There was a problem hiding this comment.
Does the maxIdxs_ needs to output?
qingqing01
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ROIPoolLayer for Fast(er) R-CNN