Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete for fp16 optimization #29715

Merged
merged 1 commit into from
Dec 17, 2020
Merged

delete for fp16 optimization #29715

merged 1 commit into from
Dec 17, 2020

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Dec 16, 2020 •
edited
Loading

PR types

Performance optimization

PR changes

OPs

Describe

输入(x_shape)/y_shape data type this PR develop
[32, 128, 728]/ [728] float16 33us 33us
[32, 128, 3072] /[3072] float16 49us5 731us

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 16, 2020 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@wangchaochaohu wangchaochaohu changed the title refine delete for fp16 optimization Dec 16, 2020
@zhangting2020
Copy link
Contributor

[32, 128, 728]/ [728]这组shape在精度问题修复后性能下降了，这个PR修改后，性能未恢复

zhangting2020
zhangting2020 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit 2e0d1ed into PaddlePaddle:develop Dec 17, 2020
@wangchaochaohu wangchaochaohu mentioned this pull request Jan 11, 2021
Merged
lanxianghit pushed a commit that referenced this pull request Jan 11, 2021
@wangchaochaohu
[cherry-pick]Elementwise add grad GPU kernel optimization (#30276)
e59524f 
* elementwise_add_grad Op optimization  (#29575)

* optimize for long width for elementwise (#29602)

* refine (#29622)

* delete the code for fp16 optimization because it is not faster than common template code (#29715)

* fix the shape choose of vectorize for cuda

* optimization for fp16 elementwise add (#29744)

* Fix the compiler error for half type (#29799)

* refine the compiler error for half2 operation (#29816)

* fix the compiler error when gcc4 cuda9.0 (#29997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangchaochaohu @zhangting2020