Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approval monitor for unity_build_rule.cmake #29701

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Add approval monitor for unity_build_rule.cmake #29701

merged 2 commits into from
Dec 17, 2020

Conversation

Avin0323
Copy link
Contributor

@Avin0323 Avin0323 commented Dec 16, 2020

PR types

Others

PR changes

Others

Describe

新增对unity_build_rule.cmake文件的监控,该文件负责管理Unity Build编译时文件组合规则。

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit bb5a785 into PaddlePaddle:develop Dec 17, 2020
@Avin0323 Avin0323 deleted the unity-build-rule-approve branch December 17, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants