Simplify the prompt of const_cast check. #29548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution! |
|
可以再简化下，删去const_cast可以不用approve |
呃， |
可以修改grep |
wadefelix
force-pushed
the
renwei-dev-const_cast
branch
from
4148e11 to
f60405f
Compare
lelelelelez
reviewed
Dec 11, 2020
tools/check_file_diff_approvals.sh
Outdated
| if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then | ||
| echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for the usage (either add or delete) of const_cast.\n" | ||
| echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for the usage of const cast.\n" |
There was a problem hiding this comment.
const cast -> const_cast
只检查增的情况，不检查删除情况
wadefelix
force-pushed
the
renwei-dev-const_cast
branch
from
f60405f to
3ecccbc
Compare
luotao1
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
const_cast检查语句优化，直接简化即可。