add conj op for complex types #29527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Dec 11, 2020
python/paddle/tensor/math.py
Outdated
| # [(4-4j), (5-5j), (6-6j)]]) | ||
|
|
||
| """ | ||
| check_type(input, 'input', (Variable, tuple, list), 'conj') |
There was a problem hiding this comment.
这里注意下写法要分动静态图，现在这样写动态图性能会受影响，https://github.com/PaddlePaddle/Paddle/wiki/paddle_api_development_manual.md
There was a problem hiding this comment.
这里应该只支持Variable，包括后面的检查，需要再修改下
chenwhql
reviewed
Dec 11, 2020
| elif tensor_to_check_dtype == np.complex64: | ||
| return tensor._get_complex64_element(i) | ||
| elif tensor_to_check_dtype == np.complex128: | ||
| return tensor._get_complex128_element(i) | ||
| else: | ||
| return tensor._get_double_element(i) |
There was a problem hiding this comment.
建议把else单独抛出异常，double的判断还放到上面，类似：
elif tensor_to_check_dtype == np.float64:
tensor._set_double_element(i, e)
elif tensor_to_check_dtype == np.complex64:
tensor._set_complex64_element(i, e)
elif tensor_to_check_dtype == np.complex128:
tensor._set_complex128_element(i, e)
else:
raise TypeError("Unsupported test data type %s." %
tensor_to_check_dtype)
| elif tensor_to_check_dtype == np.complex64: | ||
| tensor._set_complex64_element(i, e) | ||
| elif tensor_to_check_dtype == np.complex128: | ||
| tensor._set_complex128_element(i, e) |
chenwhql
reviewed
Dec 15, 2020
paddle/fluid/operators/conj_op.cc
Outdated
| namespace paddle { | ||
| namespace operators { | ||
|
|
||
| using framework::OpKernelType; |
There was a problem hiding this comment.
remove these two using declaration?
paddle/fluid/operators/conj_op.cc
Outdated
| OP_INOUT_CHECK(ctx->HasOutput("Out"), "Output", "Out", "conj"); | ||
|
|
||
| auto in_dims = ctx->GetInputDim("X"); | ||
| auto outs_names = ctx->Outputs("Out"); |
There was a problem hiding this comment.
this out_names is useless?
chenwhql
reviewed
Dec 15, 2020
paddle/fluid/operators/conj_op.h
Outdated
| void Compute(const framework::ExecutionContext& context) const override { | ||
| const Tensor* x = context.Input<Tensor>("X"); | ||
| Tensor* out = context.Output<Tensor>("Out"); | ||
| out->mutable_data<T>(context.GetPlace(), size_t(x->numel() * sizeof(T))); |
There was a problem hiding this comment.
here only need one mutable_data?
chenwhql
reviewed
Dec 15, 2020
python/paddle/tensor/math.py
Outdated
| This function computes the conjugate of the Tensor elementwisely. | ||
|
|
||
| Args: | ||
| input (list): A list of Variables which hold input Tensors with the same |
There was a problem hiding this comment.
here is input (Tensor)? why list?
chenwhql
reviewed
Dec 15, 2020
python/paddle/tensor/math.py
Outdated
| user to set this property. For more information, please refer to :ref:`api_guide_Name` | ||
|
|
||
| Returns: | ||
| out (Variable): The conjugate of inputs. The shape and data type is the same with input. \ |
chenwhql
reviewed
Dec 15, 2020
chenwhql
reviewed
Dec 16, 2020
lanxianghit
previously approved these changes
Dec 16, 2020
chenwhql
reviewed
Dec 16, 2020
python/paddle/tensor/math.py
Outdated
| This function computes the conjugate of the Tensor elementwisely. | ||
|
|
||
| Args: | ||
| x (Tensor): The input thensor which hold the complex numbers. |
MingMingShangTian
dismissed stale reviews from lanxianghit and chenwhql
via
b5ee789
chenwhql
pushed a commit
to chenwhql/Paddle
that referenced
this pull request
Dec 18, 2020
* add conj op for complex types * add conj for complex types * add more test case * add conj_op test * modify conj api and impl * add complex type for fill_constant_op xpu * add setConstant for complex type * remove complex conj test file * user define grad for test_conj_op * add test case for static mode of conj api * modify conj doc * change input args name to x * remove useless codes * conj support real types * add conj test case for real number
lanxianghit
pushed a commit
that referenced
this pull request
Dec 18, 2020
* Add complex dtype op (add) test example (#29603) * add op test case for complex * polish code details * add xpu set constant support * fix argument rror * remove useless pyc file * [Complex] Add real & imag op and api for complex tensor (#29672) * add complex real op & api & unittest * add imag op & api & unittest * refactor op impl * revert simplify writing due to complile failed * polish details * polish grad op code * add conj op for complex types (#29527) * add conj op for complex types * add conj for complex types * add more test case * add conj_op test * modify conj api and impl * add complex type for fill_constant_op xpu * add setConstant for complex type * remove complex conj test file * user define grad for test_conj_op * add test case for static mode of conj api * modify conj doc * change input args name to x * remove useless codes * conj support real types * add conj test case for real number Co-authored-by: chentianyu03 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
add conjugate op for complex types