Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and rename uniform_random API #26347

Merged
merged 9 commits into from
Aug 21, 2020

Conversation

pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Aug 17, 2020

PR types

Others

PR changes

APIs

Describe

  • Implement uniform_random API under paddle/tensor/random.py.
  • Rename uniform_random API in paddle/tensor/random.py as uniform.
  • Create alias name of paddle.tensor.random.uniformpaddle.tensor.uniform, paddle.uniform

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

assert "Error" in str(stderr), "Error: paddle.tensor.random." \
"uniform_random should not be imported"


Copy link
Contributor

@LutaoChu LutaoChu Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议新增测试,直接使用 paddle.uniform API,paddle.uniform确保可设置min,max参数,例如构造paddle.uniform([2,3], min=-5, max=5)进行测试

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@LutaoChu LutaoChu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pangyoki pangyoki force-pushed the rename_uniform_API_branch branch 5 times, most recently from 44af7fc to 89a7366 Compare August 18, 2020 09:08
@jzhang533 jzhang533 assigned jzhang533 and unassigned jzhang533 Aug 21, 2020
@jzhang533 jzhang533 self-requested a review August 21, 2020 03:04
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzhang533 jzhang533 removed their request for review August 21, 2020 03:41
@zhiqiu zhiqiu merged commit bdac6bc into PaddlePaddle:develop Aug 21, 2020
@pangyoki pangyoki changed the title Rename uniform_random API Move and rename uniform_random API Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants